Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Recipe schema org thrift #237

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Recipe schema org thrift #237

merged 4 commits into from
Mar 12, 2024

Conversation

frederickobrien
Copy link
Member

@frederickobrien frederickobrien commented Feb 22, 2024

Copy link

@frederickobrien has published a preview version of this PR with release workflow run #48, based on commit 626994c:

19.0.0-PREVIEW.agschema-org-field.2024-02-23T1023.626994ca

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/schema-org-field

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@frederickobrien has published a preview version of this PR with release workflow run #52, based on commit c5a8199:

21.0.0-PREVIEW.agschema-org-field.2024-03-01T1514.c5a81993

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/schema-org-field

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@frederickobrien has published a preview version of this PR with release workflow run #53, based on commit c5a8199:

21.0.0-PREVIEW.agschema-org-field.2024-03-01T1602.c5a81993

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/schema-org-field

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@frederickobrien has published a preview version of this PR with release workflow run #55, based on commit a555b63:

21.0.0-PREVIEW.agschema-org-field.2024-03-05T1018.a555b63a

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/schema-org-field

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@frederickobrien frederickobrien marked this pull request as ready for review March 8, 2024 17:25
@frederickobrien frederickobrien requested a review from a team as a code owner March 8, 2024 17:25
Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I’d appreciate delaying merging to discuss the (minor) points in my comments, if that’s ok?

models/src/main/thrift/content/v1.thrift Outdated Show resolved Hide resolved
models/src/main/thrift/content/schemaorg.thrift Outdated Show resolved Hide resolved
@frederickobrien frederickobrien merged commit 2656e85 into main Mar 12, 2024
1 check passed
@frederickobrien frederickobrien deleted the ag/schema-org-field branch March 12, 2024 15:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants