-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Recipe schema org thrift #237
Conversation
@frederickobrien has published a preview version of this PR with release workflow run #48, based on commit 626994c: 19.0.0-PREVIEW.agschema-org-field.2024-02-23T1023.626994ca Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command: gh workflow run release.yml --ref ag/schema-org-field Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
@frederickobrien has published a preview version of this PR with release workflow run #52, based on commit c5a8199: 21.0.0-PREVIEW.agschema-org-field.2024-03-01T1514.c5a81993 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command: gh workflow run release.yml --ref ag/schema-org-field Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
626994c
to
c5a8199
Compare
@frederickobrien has published a preview version of this PR with release workflow run #53, based on commit c5a8199: 21.0.0-PREVIEW.agschema-org-field.2024-03-01T1602.c5a81993 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command: gh workflow run release.yml --ref ag/schema-org-field Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
c5a8199
to
a555b63
Compare
@frederickobrien has published a preview version of this PR with release workflow run #55, based on commit a555b63: 21.0.0-PREVIEW.agschema-org-field.2024-03-05T1018.a555b63a Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ag/schema-org-field branch, or use the GitHub CLI command: gh workflow run release.yml --ref ag/schema-org-field Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I’d appreciate delaying merging to discuss the (minor) points in my comments, if that’s ok?
The first step in finally getting recipe schema onto the Guardian website and reaping the SEO benefits. This PR adds a Thrift definition for Schema.org recipes.
Companions downstream:
For more information on the fields included see https://schema.org/Recipe.
Preview deployed via https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/making-a-release.md#choose-release-type