-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor timeAgo
to make it more performant
#850
Conversation
🦋 Changeset detectedLatest commit: cff734b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
809ba7c
to
7df1e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider that yak shaved!
🐑 ✂️
internal changes that result in a 20× speed up, which brings the execution from 1-2µs to 60-70ns
To clarify yak shaving, I meant in a good way: "An activity that allows one to overcome intermediate difficulties, which then allows one to solve a larger problem." As in avoiding death of a thousand papercuts on performance. |
What are you changing?
timeAgo
reformatted the tests (unintentionally)→ Format@guardian/libs
with Prettier #852Why?