-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Slideshow: allow carousel interaction in cards #12852
Merged
Merged
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +3.58 kB (+0.38%) Total Size: 944 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Nov 18, 2024
jamesmockett
force-pushed
the
jm/slideshow-overlay-interaction
branch
from
November 18, 2024 11:24
c3f9063
to
dd53151
Compare
cemms1
reviewed
Nov 18, 2024
jamesmockett
force-pushed
the
jm/slideshow-overlay-interaction
branch
from
November 18, 2024 17:08
dd53151
to
5ffe8e2
Compare
cemms1
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
jamesmockett
force-pushed
the
jm/slideshow-overlay-interaction
branch
from
November 19, 2024 15:00
5ffe8e2
to
5e62b72
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Nov 19, 2024
Seen on PROD (merged by @jamesmockett 10 minutes and 1 second ago) Please check your changes! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
This allows slideshows to be interacted with when added to a front.
Part of the work to support slideshow carousels in DCR, bringing parity between web and app.
Images