-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use npm in webpack, not checked in bower packages #15818
Conversation
# Conflicts: # package.json # yarn.lock
PR build results: screenshots exceptions (1) webpagetest results -automated message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Amazing
hit a blocker: currently we serve |
raised an issue googleads/videojs-ima#333 |
tempted to downgrade our version till ima updates - seems like it might be a while, and we're running (potentially) incompatible versions as it is. we'll mainly miss out on videojs/video.js#2638. any feelings either way @SiAdcock @akash1810? |
@sndrs 👍 but could we do this in a test to be sure there isn't a detrimental loss of video consumption as a result? |
how long would we have to run it for? according to #11821, it was only to bring it inline with contribs anyway? |
Ah, I wasn't aware of that! In that case, I'm all for downgrading. |
What does this change?
What is the value of this and can you measure success?
Does this affect other platforms - Amp, Apps, etc?
no