Use Pull Request grouping to reduce PR noise #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In October 2022 scala-steward-org/scala-steward#2714 introduced the capability to group together pull requests. If you want, you can have all updates go into one single PR, or you can also group by criteria, so that noisy releasers (like AWS SDK) are grouped into one PR, while everything else goes into another PR (these might be more significant updates that people would want to consider more urgently). The behaviour (I _think_) appears to be that once a grouped PR is created, it's _not_ updated with new updates, so you have to merge it before you get another round of updates - but I don't think that's so bad. It certainly dramatically reduces update noise. I've been using it on https://github.com/guardian/play-secret-rotation and I'd say it behaves well. This department-wide config change was discussed at the P&E Server-side meetup on 1st February 2023, to positive assent (I just never got around to making the PR until now!). https://docs.google.com/document/d/1wtZPwICuEeMQ8Ga7ErUIMZsWalnsI0DpnvnkNI3Qy5U/edit#heading=h.vjxmdl6a7ue3 https://github.com/scala-steward-org/scala-steward/blob/dc85945c95c69cb8dce3d4b5f862e41ecd692417/docs/repo-specific-configuration.md?plain=1#L37-L72
NovemberTang
approved these changes
May 24, 2023
rtyley
added a commit
to guardian/google-search-indexing-observatory
that referenced
this pull request
May 26, 2023
No longer needed after guardian/scala-steward-public-repos#40
|
As a clean-up operation for this, I've manually closed the ~420 legacy ungrouped PRs that Scala Steward had previously opened before this change meant that Scala Steward would group its PRs. The old PRs were no longer being maintained by Scala Steward, so it makes sense to close them! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In October 2022 scala-steward-org/scala-steward#2714 introduced the capability to group together pull requests with
pullRequests.grouping. If you want, you can have all updates go into one single PR, or you can also group by criteria, so that noisy releasers (like AWS SDK) are grouped into one PR, while everything else goes into another PR (these might be more significant updates that people would want to consider more urgently). This dramatically reduces update noise!Instead of getting multiple individual PRs called things like:
...Scala Steward will now only ever open 2 PRs:
I've been using it on guardian/play-secret-rotation and I'd say it behaves well (see some example resulting PRs: non-AWS & AWS):
Department consensus
This department-wide config change was discussed at the P&E Server-side meetup on 1st February 2023, to positive assent - I just never got around to making the PR until now!