-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ability to avoid autoreplace \\ in patterns even on Windows #24
Comments
This is definitely something we can look into. How would you feel about adding an options object and an option to disable that? I'm thinking the option makes sense so we can have backwards compatibility but maybe it's time to drop the replacement hack. I'm not sure. |
IMHO, I would prefer to remove this hack (glob patterns by design works only with forward slashes). However, this is a major change for gulp users. I can create a PR with with these changes (without major changes): |
@mrmlnc looks great! Please send a PR. I will release a minor version with that change and then we can drop the hack all together in a major. |
I have one pattern that uses escaping for parenthesis:
As a result of the work I get:
Obviously, this is an incorrect parent directory. Yeap, I understand that this is described in the documentation, but I find it difficult to get all users to use the new format. Also I see no reason to change user input inside my package, because it can lead to problems.
Maybe we can add an option to control automatic replacement?
glob-parent/index.js
Lines 15 to 17 in d497548
Found this issue in mrmlnc/fast-glob#223. The
fast-glob
package only accepts patterns with forward slashes.The text was updated successfully, but these errors were encountered: