Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Finish the TODO for gulp.src list of globs orderings. #22

Closed
bradobro opened this issue Aug 29, 2014 · 4 comments
Closed

Finish the TODO for gulp.src list of globs orderings. #22

bradobro opened this issue Aug 29, 2014 · 4 comments

Comments

@bradobro
Copy link

@contra, I want to follow up on a TODO code comment by you near index.js:85:

    var uniqueStream = unique('path');
    // TODO: set up streaming queue so items come in order
    return aggregate.pipe(uniqueStream);

Are you thinking this is still a possible PR for Gulp now, something that should wait for Gulp 4, or something that doesn't belong in Gulp core.

I see this issue has drifted across several repos and caused more than a little aggravation; I bring it up here because it seems the best point in the code to introduce a consistent way to make gulp.src([...list-of-globs...] align with the ordering documented in gulp's readme:

Files will be concatenated in the order that they are specified in the gulp.src function. For example, to concat ./lib/file3.js, ./lib/file1.js and ./lib/file2.js in that order, the following code will create a task to do that.

@yocontra
Copy link
Member

AFAIK This already works - If you give gulp.src an array of globs it will do each glob in order

@bradobro
Copy link
Author

Okay. Closing for now until I can confirm in code.

@bradobro
Copy link
Author

You are right @contra, the ordering works sanely. '`gulp.src([glob,glob,...]) emits the vfs files from globs sequentially. Apologies for the false issue.

@yocontra
Copy link
Member

No problem, I'll remove that comment

yocontra added a commit that referenced this issue Aug 29, 2014
phated pushed a commit that referenced this issue Feb 16, 2017
phated pushed a commit that referenced this issue Feb 16, 2017
phated pushed a commit that referenced this issue Feb 16, 2017
phated pushed a commit that referenced this issue Feb 16, 2017
phated pushed a commit that referenced this issue Feb 20, 2017
phated pushed a commit that referenced this issue Feb 21, 2017
phated pushed a commit that referenced this issue Feb 21, 2017
phated pushed a commit that referenced this issue Feb 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants