Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test refactor #72

Closed
phated opened this issue Sep 8, 2016 · 4 comments
Closed

Test refactor #72

phated opened this issue Sep 8, 2016 · 4 comments
Assignees
@phated
Milestone
6.0

Comments

@phated
Copy link
Member

phated commented Sep 8, 2016

Need to bring the tests inline with other repos, switch from should to expect.
@phated phated modified the milestone: 6.0 Sep 8, 2016
@phated
Copy link
Member Author

phated commented Dec 30, 2016

Assigned to @contra incase he has time to align these tests with the other repositories (vinyl-fs is probably the best example for streams testing)

@yocontra
Copy link
Member

@phated What repo should I look at to compare with? vinyl-fs?

@phated
Copy link
Member Author

phated commented Dec 30, 2016

@contra yeah, vinyl-fs has refactored/updated tests that use mississippi utilities for testing.

@phated
Copy link
Member Author

phated commented Jan 2, 2017

Thanks @contra. I'm going to reopen because there are some stream tweaks I want to make (e.g. Using pump to handle errors, etc)

@phated phated reopened this Jan 2, 2017
@yocontra yocontra assigned phated and unassigned yocontra Jan 2, 2017
@phated phated closed this as completed in 4e60d09 Feb 3, 2017
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
2d75674
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
8897c17
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
bcd0953
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
fcade7a
phated added a commit that referenced this issue Feb 20, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
1a726f9
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
b3257e4
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
f68d43d
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
af3e749
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
b5f78ad
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
71e5557
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
51c7fb4
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
3decbdf
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
d5a354f
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Complete test refactor (closes #72) (#88)
8a84056
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@phated phated

Labels
None yet
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@yocontra @phated