-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
multi-ifo changes to pycbc_page_segtable #2519
multi-ifo changes to pycbc_page_segtable #2519
Conversation
Can you post links to some tests Gareth? |
Segtable with 3 IFOs and multiple rows to check: https://ldas-jobs.ligo.caltech.edu/~gdavies/testoutput/test_segtable_output.html I'm not sure how this will look on the actual results page though, as it is now a much wider table Edit: |
@spxiwh OK on the output from my point of view, however the functions to iterate over ifo combinations ( |
a1efab8
to
7ce67cd
Compare
7ce67cd
to
4cc98a8
Compare
@spxiwh can you look at this/review briefly? the one issue I had is whether the powerset_ifos function either exists elsewhere already or belongs in a library module, eg in the workflow module ? |
looking at https://ldas-jobs.ligo.caltech.edu/~gdavies/testoutput/H1L1-PAGE_SEGTABLE_VETO_SUMMARY-1187312718-428100.html in #2509 has made me want to have a look at this again at some point, need to understand if this is doing this right I'm not sure if V1 segments are in a dfferent format and therefore need special treatment (Fixed by 5fd82e9, see https://ldas-jobs.ligo.caltech.edu/~gdavies/testoutput/H1L1-PAGE_SEGTABLE_VETO_SUMMARY-1187312718-428100-V2.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will ignore the powerset_ifos question (git grep powerset gives nothing) & merge when ready
Making it so that H1 & L1 are not longer hardcoded, and that the table output now has all possible detector combinations