-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implemetn combine statmap and injfind into wf #2539
Merged
spxiwh
merged 18 commits into
gwastro:master
from
tapaimarton:implemetn_combine_statmap_and_injfind_into_wf
Mar 4, 2019
Merged
Implemetn combine statmap and injfind into wf #2539
spxiwh
merged 18 commits into
gwastro:master
from
tapaimarton:implemetn_combine_statmap_and_injfind_into_wf
Mar 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Codacy issue is one that we have in numerous places in how we've implemented the Executable class. At some point this should be cleaned up, but not here. Other than that, this seems to add the promised functionality, and does not touch other code, so merging to allow people to test. |
spxiwh
approved these changes
Mar 4, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the combine statmap and injfind into the workflow