Foregroud minifollowup dev #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
March 16, 2019 08:21
…eturn an empty fig with title '{IFO}: no triggers'
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
| ifo_list = f.attrs['ifos'].split(' ') | ||
| for ifo in ifo_list: | ||
| idx[ifo] = d['%s/trigger_id' % ifo][n] | ||
|
|
||
| # Store the single detector trigger files keyed by ifo in a dictionary | ||
| table = [] | ||
| files = {} |
There was a problem hiding this comment.
Happy with the changes in this code.
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
spxiwh
reviewed
Mar 19, 2019
spxiwh
requested changes
Mar 19, 2019
There was a problem hiding this comment.
Thanks @tapaimarton I only request changes on the two plotting codes as indicated. I also express a preference for not making plots for non-participating ifos, but will approve this either way.
|
No new issues being reported by CodeClimate, so no obligations there. |
spxiwh
approved these changes
Mar 22, 2019
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
* fix foreground_minifollowup for multiifo use
* add foreground_minifollowup to workflow
* add missing sort
* If pycbc_plot_singles_timefreq recieves centert time = -1.0 it will return an empty fig with title '{IFO}: no triggers'
* update qscan to be able to handle -1.0 trig time
* trailing space
* fix
* next fix
* fix qscan error
* fix indent in plot_qscan
* fix plotscan
* fix page_coincinfo for multiifo workflow
* fix plot_singles_timefreq
* another fix
* fix
* do not try to plot single template when detector is offline
* more fix
* exit if time is invalid
* fix minifollowup setup
* use sys.exit(0) in pycbc_plot_qscan and pycbc_plot_singles_timefreq
* don't add line for ifo with time == -1.0
* fix opening statmapfile
* fix missing [n]
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the foreground minifollow to work. See slack for the test run and the page created.