added Left and Right Circular Projection matrix #3599

JAMSADIQ · 2021-01-27T10:05:45Z

Added a new function in this code for left and right circular polarization projection matrix.

spxiwh · 2021-01-27T13:36:47Z

@a-r-williamson I've assigned this one to you to look over.

…rgument in null-snr function to avoid null cuts; and removed some extra comments.

fix a bracket in pycbc_reweight_snr function

JAMSADIQ · 2021-11-10T09:11:48Z

With the above commits now pycbc-multi-inspiral and lalapps_coh_PTF_inspiral code give same results when using left anf right circular polarization matrices. The details can be found at https://wiki.ligo.org/Bursts/CircularlyPolarizedProjectionMatrix
In order to check the code for accepting merge request my modified code can be used for an injection test with command line options given in https://wiki.ligo.org/Bursts/CircularlyPolarizedProjectionMatrix page.

a-r-williamson · 2021-11-15T14:48:24Z

bin/pycbc_multi_inspiral

@@ -107,6 +107,7 @@ parser.add_argument("--null-step", type=float, default=20., help="""
 parser.add_argument("--trigger-time", type=int, help="""
                    Time of the GRB, used to set the antenna patterns.""")

+parser.add_argument("--projection-type", default='standard', type=str, help="""Choice of projection matrix with standard, left circular or right circular""")


Suggested change

parser.add_argument("--projection-type", default='standard', type=str, help="""Choice of projection matrix with standard, left circular or right circular""")

parser.add_argument("--projection-type", default="standard",

choices=["standard", "left", "right", "left+right"],

help="Choice of projection matrix. 'Left' and 'right' "

"correspond to face-away and face-on.")

a-r-williamson · 2021-11-15T14:50:49Z

bin/pycbc_multi_inspiral

@@ -211,6 +211,16 @@ def get_projection_matrix(wp, wc):
    return projection_matrix


+def circular_projection_matrix(wp, wc):


Can we perhaps unify this into the above function get_projection_matrix which could have a kwarg for the projection name?

a-r-williamson · 2021-11-15T14:51:34Z

bin/pycbc_multi_inspiral

@@ -513,6 +528,10 @@ with ctx:
            sigma = {ifo : np.sqrt(sigmasq[ifo]) for ifo in opt.instruments}
            # Every time s_num is zero or we skip the segment, we run new 
            # template to increment the template index
+            ####### Testing values


Suggested change

####### Testing values

a-r-williamson · 2021-11-15T14:52:29Z

bin/pycbc_multi_inspiral

+            ####### Testing values
+            wp,wc=get_weighted_antenna_patterns(Fp,Fc,sigma)
+            projection_matrix = get_projection_matrix(wp,wc)
+            LCprojection_matrix, RCprojection_matrix = circular_projection_matrix(wp, wc)


We also need to account for the normal GRB search behaviour where both right and left projections are used.

…th a kwargs choice. Modify code before coherent snr calculation

…fy code

JAMSADIQ · 2021-11-16T11:59:22Z

I make changes and push them. Kindly check it

titodalcanton · 2021-11-16T14:37:00Z

bin/pycbc_multi_inspiral

+        return left_projection_matrix, right_projection_matrix
+
+    else:
+        logging.info("choice of projection matrix is not available")


This should probably be an exception, not a logging.info() call:

raise ValueError('unknown projection type ' + str(projection_type))

titodalcanton · 2021-11-16T14:39:06Z

bin/pycbc_multi_inspiral

+
+    if projection_type=='standard':
+        logging.info("choice of projection matrix is %s"
+                            % str(projection_type))


Calls to logging.info() should not use the string formatting operations (% and .format()). Instead, do this:

logging.info("choice of projection matrix is %s", projection_type)

(this comment also applies to logging.info() calls further below).

… rather a message for wrong option inputs

JAMSADIQ · 2021-11-16T16:56:39Z

Fixed some issues for review.

a-r-williamson

Hi @JAMSADIQ, thanks for the recent commits. I've requested a few minor changes here, which hopefully you can just click accept on then I can approve the PR.

bin/pycbc_multi_inspiral

a-r-williamson · 2022-02-02T16:35:31Z

bin/pycbc_multi_inspiral

                logging.info("%s points above coherent threshold"
                            % str(len(rho_coh)))


Suggested change

logging.info("%s points above coherent threshold"

% str(len(rho_coh)))

logging.info("%d points above coherent threshold", len(rho_coh))

a-r-williamson · 2022-02-02T16:37:32Z

bin/pycbc_multi_inspiral

                    logging.info("Max coincident SNR = %s"
                                % str(max(rho_coinc)))


Suggested change

logging.info("Max coincident SNR = %s"

% str(max(rho_coinc)))

logging.info("Max coincident SNR = %.2f", max(rho_coinc))

Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com>

…gging info statments

* added Left and Right Circular Projection matrix * make some changes in projection matrix * Deleted the file from the git repository * removed extra commented lines * fix bug in new function denominator term * "added option to save network chi squared in he output hdf file" * replace reweighted-snr with coherent-snr in clustering; added a new argument in null-snr function to avoid null cuts; and removed some extra comments. * Update pycbc_multi_inspiral fix a bracket in pycbc_reweight_snr function * fixed the argparser option for projection type * modify projection matrix function adding left and right projection with a kwargs choice. Modify code before coherent snr calculation * added the option of left_right in projection matrix function and modify code * fixed some typos * minor changes * fixed logging info string formatting operations and use of ValueError rather a message for wrong option inputs * removed extra function of circular polarization * make changes in coding several line for recomended coding * Update bin/pycbc_multi_inspiral Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com> * make some suggested minor chnages in a comment of function and few logging info statments Co-authored-by: Jam Sadiq <jam.sadiq@ldas-pcdev1.ligo.caltech.edu> Co-authored-by: Jam Sadiq <jam.sadiq@ldas-pcdev6.ligo.caltech.edu> Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com>

spxiwh requested a review from a-r-williamson January 27, 2021 13:36

spxiwh assigned a-r-williamson Jan 27, 2021

a-r-williamson added this to the PyGRB - Phase 1 milestone Jan 27, 2021

a-r-williamson added the PyGRB PyGRB development label Oct 12, 2021

JAMSADIQ mentioned this pull request Oct 25, 2021

Issue with null-snr cutoff and using reweighted-snr as input in clustering function #3847

Closed

Jam Sadiq and others added 8 commits November 8, 2021 07:28

added Left and Right Circular Projection matrix

b25461e

make some changes in projection matrix

4938b22

Deleted the file from the git repository

e9b577b

removed extra commented lines

46382bf

fix bug in new function denominator term

b01d3e9

"added option to save network chi squared in he output hdf file"

5a05f87

replace reweighted-snr with coherent-snr in clustering; added a new a…

840e81c

…rgument in null-snr function to avoid null cuts; and removed some extra comments.

Update pycbc_multi_inspiral

1ea3720

fix a bracket in pycbc_reweight_snr function

JAMSADIQ force-pushed the pygrbtests branch from b1452d9 to 1ea3720 Compare November 8, 2021 15:38

a-r-williamson reviewed Nov 15, 2021

View reviewed changes

JAMSADIQ added 5 commits November 15, 2021 08:58

fixed the argparser option for projection type

2f92f91

modify projection matrix function adding left and right projection wi…

d8d9c6c

…th a kwargs choice. Modify code before coherent snr calculation

added the option of left_right in projection matrix function and modi…

37da734

…fy code

fixed some typos

26f5eb0

minor changes

150895a

JAMSADIQ force-pushed the pygrbtests branch from 482ebee to 150895a Compare November 16, 2021 11:57

titodalcanton reviewed Nov 16, 2021

View reviewed changes

JAMSADIQ added 2 commits November 16, 2021 08:47

fixed logging info string formatting operations and use of ValueError…

3f9d882

… rather a message for wrong option inputs

removed extra function of circular polarization

ce50777

JAMSADIQ added 2 commits February 1, 2022 09:14

make changes in coding several line for recomended coding

07f2c17

Merge branch 'gwastro:master' into pygrbtests

df95242

a-r-williamson requested changes Feb 2, 2022

View reviewed changes

JAMSADIQ and others added 2 commits February 2, 2022 17:49

Update bin/pycbc_multi_inspiral

0472338

Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com>

make some suggested minor chnages in a comment of function and few lo…

9825d3d

…gging info statments

a-r-williamson approved these changes Feb 2, 2022

View reviewed changes

a-r-williamson enabled auto-merge (squash) February 2, 2022 17:23

a-r-williamson merged commit 65c123b into gwastro:master Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added Left and Right Circular Projection matrix #3599

added Left and Right Circular Projection matrix #3599

JAMSADIQ commented Jan 27, 2021

spxiwh commented Jan 27, 2021

JAMSADIQ commented Nov 10, 2021

a-r-williamson Nov 15, 2021

a-r-williamson Nov 15, 2021

a-r-williamson Nov 15, 2021

a-r-williamson Nov 15, 2021

JAMSADIQ commented Nov 16, 2021

titodalcanton Nov 16, 2021

titodalcanton Nov 16, 2021 •

edited

Loading

JAMSADIQ commented Nov 16, 2021

a-r-williamson left a comment

a-r-williamson Feb 2, 2022

a-r-williamson Feb 2, 2022

-parser.add_argument("--projection-type", default='standard', type=str, help="""Choice of projection matrix with standard, left circular or right circular""")
+parser.add_argument("--projection-type", default="standard",
+                    choices=["standard", "left", "right", "left+right"],
+                    help="Choice of projection matrix. 'Left' and 'right' "
+                         "correspond to face-away and face-on.")

		@@ -211,6 +211,16 @@ def get_projection_matrix(wp, wc):
		return projection_matrix


		def circular_projection_matrix(wp, wc):

		logging.info("%s points above coherent threshold"
		% str(len(rho_coh)))

	logging.info("%s points above coherent threshold"
	% str(len(rho_coh)))
	logging.info("%d points above coherent threshold", len(rho_coh))

		logging.info("Max coincident SNR = %s"
		% str(max(rho_coinc)))

	logging.info("Max coincident SNR = %s"
	% str(max(rho_coinc)))
	logging.info("Max coincident SNR = %.2f", max(rho_coinc))

added Left and Right Circular Projection matrix #3599

added Left and Right Circular Projection matrix #3599

Conversation

JAMSADIQ commented Jan 27, 2021

spxiwh commented Jan 27, 2021

JAMSADIQ commented Nov 10, 2021

a-r-williamson Nov 15, 2021

Choose a reason for hiding this comment

a-r-williamson Nov 15, 2021

Choose a reason for hiding this comment

a-r-williamson Nov 15, 2021

Choose a reason for hiding this comment

a-r-williamson Nov 15, 2021

Choose a reason for hiding this comment

JAMSADIQ commented Nov 16, 2021

titodalcanton Nov 16, 2021

Choose a reason for hiding this comment

titodalcanton Nov 16, 2021 • edited Loading

Choose a reason for hiding this comment

JAMSADIQ commented Nov 16, 2021

a-r-williamson left a comment

Choose a reason for hiding this comment

a-r-williamson Feb 2, 2022

Choose a reason for hiding this comment

a-r-williamson Feb 2, 2022

Choose a reason for hiding this comment

titodalcanton Nov 16, 2021 •

edited

Loading