-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PyGRB post-processing #3972
Merged
Merged
PyGRB post-processing #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fixing imports in PyGRB post-processing executables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pannarale Looks good, just one query.
a-r-williamson
approved these changes
Apr 22, 2022
pannarale
added a commit
to pannarale/pycbc
that referenced
this pull request
Apr 27, 2022
* Placing GRB trigger information at the start of the results webpage and fixing imports in PyGRB post-processing executables * Cleaning up old PyGRB results webpage material * Turning slide_dict into an actual dictionary and using its dictionary powers * Reinserting delete k...
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
May 12, 2022
* Placing GRB trigger information at the start of the results webpage and fixing imports in PyGRB post-processing executables * Cleaning up old PyGRB results webpage material * Turning slide_dict into an actual dictionary and using its dictionary powers * Reinserting delete k...
spxiwh
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Selecting the offsource trials randomly, rather than sequentially * Counting trials from 1, as per the previous convention * print --> back to a vprint * Avoiding repetition of offtrials * Avoiding repetition of offtrials * PyGRB post-processing (#3972) * Placing GRB trigger information at the start of the results webpage and fixing imports in PyGRB post-processing executables * Cleaning up old PyGRB results webpage material * Turning slide_dict into an actual dictionary and using its dictionary powers * Reinserting delete k... * More detailed description for GRB sky error func (#2975) * More detailed description for GRB sky error func Also included a new argument to allow for different probability coverage. Default is the same as old hardcoded value of 90%. * Updating Fermi-GBM systematics for GRB sky grids * updating Changes to grb_utils so get_sky_grid_error is correctly called * Removing precision argument no longer needed in get_sky_grid_scale * remove whitespace in grb_utils * Fixing indent bug caused by GitHub web interface * Fixing some CodeClimate issues * Remove unused import * Revert "Removing precision argument no longer needed in get_sky_grid_scale" This reverts commit af4e1fa. * CodeClimate * More CodeClimate Co-authored-by: Tessa Carver <tessa.carver@ligo.org> Co-authored-by: tcarver1234 <40335373+tcarver1234@users.noreply.github.com> * Add chisq cut to pycbc_multi_inspiral (#3989) * First attempt at newsnr cut function * Added call to rw snr cut + None case handled * Rewrote newsnr cut for efficiency * Adding test of pycbc_multi_inspiral face-on/-away (#3933) * Adding test of pycbc_multi_inspiral face-on/-away * faceon script minor tweaks * Add PyGRB test to test suite * Minor tweak to faceon_faceaway check * Adding GW170817 example * 170817 test hardened * Removing test urls from shell scripts * Setting seed default to None * Fixing seed type and default for pycbc_grb_trig_combiner. Let numpy.random.seed deal with the type, rather than enforcing it here * pycbc_geom_aligned_bank update to intermediate-data-file and metadata-file handling Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com> Co-authored-by: Tessa Carver <tessa.carver@ligo.org> Co-authored-by: tcarver1234 <40335373+tcarver1234@users.noreply.github.com> Co-authored-by: Jacob Buchanan <83317255+jakeb245@users.noreply.github.com>
connor-mcisaac
pushed a commit
to connor-mcisaac/pycbc
that referenced
this pull request
Aug 23, 2022
* Placing GRB trigger information at the start of the results webpage and fixing imports in PyGRB post-processing executables * Cleaning up old PyGRB results webpage material * Turning slide_dict into an actual dictionary and using its dictionary powers * Reinserting delete k...
connor-mcisaac
pushed a commit
to connor-mcisaac/pycbc
that referenced
this pull request
Oct 12, 2022
* Selecting the offsource trials randomly, rather than sequentially * Counting trials from 1, as per the previous convention * print --> back to a vprint * Avoiding repetition of offtrials * Avoiding repetition of offtrials * PyGRB post-processing (gwastro#3972) * Placing GRB trigger information at the start of the results webpage and fixing imports in PyGRB post-processing executables * Cleaning up old PyGRB results webpage material * Turning slide_dict into an actual dictionary and using its dictionary powers * Reinserting delete k... * More detailed description for GRB sky error func (gwastro#2975) * More detailed description for GRB sky error func Also included a new argument to allow for different probability coverage. Default is the same as old hardcoded value of 90%. * Updating Fermi-GBM systematics for GRB sky grids * updating Changes to grb_utils so get_sky_grid_error is correctly called * Removing precision argument no longer needed in get_sky_grid_scale * remove whitespace in grb_utils * Fixing indent bug caused by GitHub web interface * Fixing some CodeClimate issues * Remove unused import * Revert "Removing precision argument no longer needed in get_sky_grid_scale" This reverts commit af4e1fa. * CodeClimate * More CodeClimate Co-authored-by: Tessa Carver <tessa.carver@ligo.org> Co-authored-by: tcarver1234 <40335373+tcarver1234@users.noreply.github.com> * Add chisq cut to pycbc_multi_inspiral (gwastro#3989) * First attempt at newsnr cut function * Added call to rw snr cut + None case handled * Rewrote newsnr cut for efficiency * Adding test of pycbc_multi_inspiral face-on/-away (gwastro#3933) * Adding test of pycbc_multi_inspiral face-on/-away * faceon script minor tweaks * Add PyGRB test to test suite * Minor tweak to faceon_faceaway check * Adding GW170817 example * 170817 test hardened * Removing test urls from shell scripts * Setting seed default to None * Fixing seed type and default for pycbc_grb_trig_combiner. Let numpy.random.seed deal with the type, rather than enforcing it here * pycbc_geom_aligned_bank update to intermediate-data-file and metadata-file handling Co-authored-by: Andrew R. Williamson <a-r-williamson@users.noreply.github.com> Co-authored-by: Tessa Carver <tessa.carver@ligo.org> Co-authored-by: tcarver1234 <40335373+tcarver1234@users.noreply.github.com> Co-authored-by: Jacob Buchanan <83317255+jakeb245@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to the results webpage, i.e., a table with the GRB trigger information.
Additionally, it begins a clean up of old material involved in the production of PyGRB results webpages.