Use SkyGrid functions to write the HDF5 file and fix error in angular convention #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
requested changes
Jan 7, 2025
added 3 commits
January 8, 2025 14:12
attribute into detectors (doesn't work)
Thomas-JACQUOT
force-pushed
the
sky_grid_fix
branch
from
4074e7b to
44eff8d
Compare
titodalcanton
requested changes
Jan 8, 2025
added 2 commits
January 8, 2025 17:01
titodalcanton
approved these changes
Jan 8, 2025
titodalcanton
changed the title
pannarale
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thank you @Thomas-JACQUOT and @titodalcanton. This looks good!
titodalcanton
changed the title
|
We also realized that the angular convention used by |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a change in the
pycbc_make_sky_gridscript that useinstrumentsattribute name for detectors and theSkyGridclass was usingdetectorsThis change affects: sky grid scripts and PyGRB
Motivation
@titodalcanton and I want to make some PyGRB runs on GRB190427A which has a non zero sky error which will fail if this error is not fixed (see this discussion)