Ensure pygrb webpage is generated after all results files are produced #5025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyGRB webpages often had gaps that could be fixed by running the
pycbc_make_html_page
job by hand, after a full workflow was completed. This was a sign of incorrect dependencies in the workflow (i.e.,pycbc_make_html_page
was being called too early).To fix this, this PR simply moves the call to
make_results_web_page
further down in thepycbc_pygrb_results_workflow
workflow generator, so that the job dependencies are correct: all nodes that will give jobs that produce plots, tables, etc. are now in the collection of dependencies passed tomake_results_web_page
, sopycbc_make_html_page
runs after those jobs.This is a: bug fix.
This change affects: PyGRB
I produced this results webpage from a short workflow with no need to "sync" it by hand after the workflow had finished running.