Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: add test for MPI_Barrier #35

Merged
merged 1 commit into from
Mar 24, 2025
Merged

test: add test for MPI_Barrier #35

merged 1 commit into from
Mar 24, 2025

Conversation

gxyd
Copy link
Owner

@gxyd gxyd commented Mar 21, 2025

No description provided.

@adit4443ya
Copy link
Collaborator

adit4443ya commented Mar 22, 2025

If this PR is intended only for test then it's okay to merge
But if it's for removing barrier wrapper
Then for that i made a patch which i used but encountered an error in the lfortran while gfortran works well for which i opened an issue in here lfortran/lfortran#6720

@adit4443ya
Copy link
Collaborator

adit4443ya commented Mar 22, 2025

BTW That issue is the promiment issue which must be resolved as we use comm_f as an argument in so many subroutines and for all of them we use MPI_Comm_f2c
and for that we need that converter function properly working, that is we hshould catch type(c_ptr) correctly as the return value from the BIND(C) function , so i guess we should probably fix that issue in lfortran and then move forward
CC:@gxyd
Issue lfortran/lfortran#6720

@gxyd
Copy link
Owner Author

gxyd commented Mar 24, 2025

Then for that i made a patch which i used but encountered an error in the lfortran while gfortran works well for which i opened an issue in here lfortran/lfortran#6720

Can you send a PR against this repo with that? That will allow us to see which tests (if any) that fail.

@gxyd
Copy link
Owner Author

gxyd commented Mar 24, 2025

I'm merging this PR to just allow us to have a test case with MPI_Barrier.

@gxyd gxyd merged commit ce5d017 into main Mar 24, 2025
8 checks passed
@gxyd gxyd deleted the barrier_subroutine branch March 24, 2025 14:13
@adit4443ya
Copy link
Collaborator

Can you send a PR against this repo with that? That will allow us to see which tests (if any) that fail.

ITs in here #37

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants