-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(#77): fakehub stop via cli::sys #192
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 82.19% 74.69% -7.50%
==========================================
Files 16 20 +4
Lines 292 328 +36
==========================================
+ Hits 240 245 +5
- Misses 52 83 +31 ☔ View full report in Codecov by Sentry. |
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here. |
@h1alexbel Oops, I failed. You can see the full log here (spent 12min).
|
@rultor release, tag is |
@h1alexbel OK, I will release it now. Please check the progress here. |
@h1alexbel Done! FYI, the full log is here (took me 18min). |
@h1alexbel Thanks for your contribution! Here's how your +4 points were calculated: +4 base, -8 for exceeding 200 hits-of-code (363), -16 for no code review, -4 for only 4 comments, and +28 to meet the minimum reward. Remember, quality over quantity is key. Try to keep contributions smaller, ensure code reviews, and encourage more comments next time. Your current balance is +35. Keep up the good work! 💻 |
In this pull I've implemented
fakehub stop
command via system calls.closes #77
History:
stop
to shutdown fakehub server #77): sysstop
to shutdown fakehub server #77): stopstop
to shutdown fakehub server #77): task::spawnstop
to shutdown fakehub server #77): cli stopstop
to shutdown fakehub server #77): typostop
to shutdown fakehub server #77): info, err for -dstop
to shutdown fakehub server #77): PIDstop
to shutdown fakehub server #77): sys_infostop
to shutdown fakehub server #77): current_portstop
to shutdown fakehub server #77): sysstop
to shutdown fakehub server #77): sys_info testsstop
to shutdown fakehub server #77): current_port test with killportstop
to shutdown fakehub server #77): docsstop
to shutdown fakehub server #77): doc typostop
to shutdown fakehub server #77): puzzlePR-Codex overview
This PR introduces a command to stop the
fakehub
server, adds system information logging, and enhances the CLI with new functionalities related to process management on UNIX systems. It also includes tests for OS detection and logging.Detailed summary
Stop
command incli/src/args.rs
.README.md
with instructions to stop the server.sys_info
function inserver/src/sys/sys_info.rs
to log OS and PID.current_port
andkill_unix
functions for managing server processes.instance_os
function to detect the operating system.instance_os
and logging insys_info
.