Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(#118): merge pom.xml files into profile #121

Merged
merged 7 commits into from
Oct 4, 2024
Merged

feat(#118): merge pom.xml files into profile #121

merged 7 commits into from
Oct 4, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 4, 2024

In this pull, I've implemented merging all pom.xml files into single profile in maven step. The following columns were added: projects, plugins, pwars, pjars, ppoms.

closes #118
History:


PR-Codex overview

This PR introduces enhancements to the maven.py script for better handling and merging of Maven project data, updates the CI workflow, and improves testing functionalities. It includes changes to variable handling, XML parsing, and adds new test cases.

Detailed summary

  • Added extend-ignore-identifiers-re in _typos.toml.
  • Updated CI workflow in .github/workflows/nightly.yml to remove "deep" from command.
  • Introduced XML parsing with xml.etree.ElementTree in sr_data/src/sr_data/steps/maven.py.
  • Enhanced main function to handle Maven project profiles.
  • Updated pom function to return merged project data.
  • Added merge function to consolidate Maven project information.
  • Introduced new test case for merging projects in sr-data/src/tests/test_maven.py.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel h1alexbel merged commit 5fdccc8 into master Oct 4, 2024
16 checks passed
@h1alexbel h1alexbel deleted the 118 branch October 4, 2024 15:15
h1alexbel added a commit that referenced this pull request Oct 7, 2024
feat(#118): merge pom.xml files into profile
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven.py:36-39: Parse 'build' JSON array of maven...
1 participant