Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(#125): skip None artifact in maven step #129

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat(#125): skip None artifact in maven step #129

merged 1 commit into from
Oct 7, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 7, 2024

closes #125


PR-Codex overview

This PR introduces a new CSV file for testing, modifies the logic in the maven.py file to handle cases where an artifact may not be present, and adds a new test case in test_maven.py to verify the behavior when a plugin lacks an artifact.

Detailed summary

  • Added to-maven-without-artifact.csv file with repository and branch information.
  • Updated logic in maven.py to check for artifact only if group is None.
  • Introduced test_skips_plugin_without_artifact in test_maven.py to test behavior when no artifact is provided.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel h1alexbel merged commit 6ab8d45 into master Oct 7, 2024
17 checks passed
@h1alexbel h1alexbel deleted the 125 branch October 7, 2024 12:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

artifact: AttributeError: 'NoneType' object has no attribute 'text' during collect.yml
1 participant