Updated known errors #112
Updated known errors #112
Conversation
updated the known issues
updated readme
|
hello @mturoci , kindly have a look and accept this PR |
README.md
Outdated
|
|
||
|
|
||
|
|
||
| **3. Python not found:** This error is probably if Windows is not able to recognise the path of Python. The path of Python can be updated in the pyvenv.cfg file, located in [App Folder]/venv |
There was a problem hiding this comment.
If python is not found, then venv cannot be created, right?
There was a problem hiding this comment.
yes , this error is shown atmost beginning and nothing works in that case, as venv not works.
There was a problem hiding this comment.
as venv not works
Then The path of Python can be updated in the pyvenv.cfg file, located in [App Folder]/venv is an invalid statement, right?
There was a problem hiding this comment.
Actually , In the app folder there is a pre loaded folder venv which comes when we clone the repo.
Now in this venv folder ,there is pyvenv.cfg file. So this file and the venv folder comes with the app. So if python is not found, it is because in this preloaded file, the address is wrong
And the Make file takes the path of python from here i guess.
So i believe this is valid statement. please do update me if anything wrong.
There was a problem hiding this comment.
I have committed and specified this thing in the file to avoid confusion. :)
There was a problem hiding this comment.
In the app folder there is a pre loaded folder venv which comes when we clone the repo
I have looked through the repo, but could not find the venv as you say. Can you point out where you see it?
There was a problem hiding this comment.
Oh thanks for highlighting that. Yes it is not there. I guess that error was specific to my pc due to difference in directories of python installation and wave-apps.
So I guess it will be good to remove this
There was a problem hiding this comment.
The missing python installation is a valid error and should be documented. You correctly included it, the only problem was your problem resolution. Please put it back with the proper way for fixing it - installing python, putting it to the PATH etc.
There was a problem hiding this comment.
As requested, I have added the python error. Kindly check
|
I have commited the changes suggested by you. kindly check, and if everything's fine mark as hacktoberfest-accepted |
|
@mturoci thanks for highlighting those points. I have updated the changes as requested. Kindly see. |
|
@mturoci kindly check |
Co-authored-by: mturoci <64769322+mturoci@users.noreply.github.com>
|
Thanks! Nice time working on this , please do add hacktoberfest accepted tag also |
|
Merging is enough to count towards your Hacktoberfest submissions, no worries :) |
|
Okay, thanks! Learned new things while working on this :) |
I tested the app on windows and mac. I was not able to arrange Linux so didn't test it on Linux.
As discussed, I have updated the errors which I saw on windows and which were known to me.
The instructions are already nice so I didn't feel they need to be simplified or so...
Kindly have a look, and if everything seems good, accept this PR and mark it as Hactoberfest accepted.