Skip to content

fix: node opens index.js instead of running closes #15 #16

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

fix: node opens index.js instead of running closes #15 #16

merged 1 commit into from
May 24, 2020

Conversation

vltansky
Copy link
Member

@vltansky vltansky commented May 24, 2020 •
edited
Loading

closes #15

@vltansky
fix: node opens index.js instead of running

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8f06425
roblarsen
roblarsen approved these changes May 24, 2020
View reviewed changes
index.js
@@ -1 +1,2 @@
#!/usr/bin/env node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake :)

@roblarsen roblarsen merged commit 16ba6ce into h5bp:master May 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@roblarsen roblarsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node tries to open index.js, doesn't run it when running npx create...
2 participants
@vltansky @roblarsen