New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

config.ini is now overloaded, hacky #177

Open

hackalog opened this issue Sep 5, 2020 · 1 comment

Owner

hackalog commented Sep 5, 2020

We've now overloaded the config.ini to include both paths[] info, and local dataset configuration. This is fragile in two ways:

references to local_config (paths._config) rely on the implementation of paths - not ideal
if you have a dataset named "Paths", you're in trouble.

To solve #2, we should reallty build a KVSingleton that is a 2-level dictionary config[section][key] mapping to an ini

Otherwise, behavior should be the same (should still be a singleton, e.g.)

to solve #1, just implement the config 2-level singleton and leave paths alone, or have paths[] inherenely reference as section called "_paths"

Owner Author

hackalog commented Nov 10, 2020

Could fix #2 more simply by namespacing the sections:

[Dataset:whatever]
[Paths]

# for free to join this conversation on GitHub. Already have an account? # to comment