Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dark Mode #514

Merged
merged 7 commits into from
Jul 13, 2024
Merged

Dark Mode #514

merged 7 commits into from
Jul 13, 2024

Conversation

BrightTheBackpack
Copy link
Member

@BrightTheBackpack BrightTheBackpack commented Jun 1, 2024

the error module dark mode is a little meh, lmk what you think
closes #174
closes #194

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blot-3dgallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 8:38pm

@leomcelroy
Copy link
Contributor

Really nice to see this come in. I see a few things aren't covered with the PR. Dropdown menus are one, and the code blocks in the help window seem off too. I attached some screenshots below.

Screenshot 2024-06-04 at 11 15 59 AM Screenshot 2024-06-04 at 11 16 06 AM

@BrightTheBackpack
Copy link
Member Author

Fixed those! Also changed the help tabs a little bit. Let me know if there's anything else you want changed!

@leomcelroy
Copy link
Contributor

Good progress. How about the modals?

There are modals for the file/log-in menus.

Screenshot 2024-06-27 at 10 58 24 PM

@BrightTheBackpack
Copy link
Member Author

oof i forgot those existed. I'll try and to do asap

@BrightTheBackpack
Copy link
Member Author

i'm at the powerpoint party at uvm rn, i'll get started right after that

@BrightTheBackpack
Copy link
Member Author

done! i also moved all the colors to variables to make it easier to make changes in the furture, and changed up the help/toolbox menu a little bit.

@leomcelroy
Copy link
Contributor

This is very close!

The text contrast is messed up on every other item in the modal.

Screenshot 2024-07-12 at 3 13 08 PM

@leomcelroy
Copy link
Contributor

I think it would be good to make the color more blue too. With that being Blot's brand. Perhaps something like #1c2e73

@BrightTheBackpack
Copy link
Member Author

good catch! i darkened the other itmes so the contrast is better, and i also made it more bluer

@maxwofford maxwofford temporarily deployed to blot-main-dad7q6zeuenrdqmkacfp July 13, 2024 16:03 Inactive
@maxwofford
Copy link
Member

This looks awesome! I'm going to merge this & get community feedback!

@maxwofford maxwofford merged commit 8a5cb0c into hackclub:main Jul 13, 2024
1 check passed
@matytyma
Copy link

matytyma commented Jul 13, 2024

A list of things I'll find over time:

  • links have same color as regular text in the toolkit window
  • spoilers in the workshop tab, syntax error popups need a recolor for dark mode
  • titles in light mode in workshop tab are white-ish now
  • brackets highlight and vim cursor look weird

@BrightTheBackpack
Copy link
Member Author

  1. for the links, do we want:
    Red for light mode
    x(suggestions open) for dark mode
    or
    Blue for light mode
    Dark blue for light mode.
    The first one reflects whats on the home page, but i think i might like the second one a little more.
  2. Any color suggestions for spoilers and error popups?
  3. fixed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode or customizable pallette color contrast
4 participants