Basic Analytics Tools #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 12, 2018 12:49
…earn into analytics_implementation
…earn into analytics_implementation # Conflicts: # mslearn/analytics/core.py # mslearn/automl/adaptors.py # mslearn/featurization/core.py # mslearn/preprocessing/core.py # mslearn/preprocessing/feature_selection.py # mslearn/utils/utils.py
…earn into analytics_implementation
…earn into analytics_implementation
|
one quick comment: when making plot methods, don’t save the fig for the time being, return the plot object. then the user can decide what to do with the plot object (see pymatgen plotting) overall i’m very stoked on this tho |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 66.79% 69.61% +2.81%
==========================================
Files 23 23
Lines 1262 1211 -51
==========================================
Hits 843 843
+ Misses 419 368 -51
Continue to review full report at Codecov.
|
|
btw don’t worry about failing codecov check |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functioning Analytics object that can take a fit MatPipe object and perform operations for interpreting, visualizing, and using the produced model. Currently only supports model agnostic feature importance and single feature partial dependency plotting.