Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement and document CSS-in-JS best practices for CIVIC #556

Open
4 of 5 tasks
jaronheard opened this issue May 23, 2019 · 0 comments
Open
4 of 5 tasks

Implement and document CSS-in-JS best practices for CIVIC #556

jaronheard opened this issue May 23, 2019 · 0 comments
Labels
planning:Epic A single issue that documents a large project bridging multiple issues.

Comments

@jaronheard
Copy link
Contributor

jaronheard commented May 23, 2019

From our Front-End Charter, one of our tactical goals is to determine CSS-in-JS best practices

We'd like to have consistent pattern of how we use CSS-in-JS across CIVIC, so that CIVIC developers, from newcomers to long-time contributors, have patterns to follow.

The items below document some of the components of this epic. If this is an epic that someone wants to take ownership over, please feel empowered to do that!

Complete emotion 10 upgrade:

Known current issues:

#433 Fixes all of these:

Note -- notify elections once removed

  • No common place for shared styling

  • No common place for colors (currently stored in the VictoryTheme for data visualization components here

  • No consistent pattern for passing custom styling to components (could be extended to Implement theming in component library #433)

After Demo Day:

@jaronheard jaronheard added the planning:Epic A single issue that documents a large project bridging multiple issues. label May 23, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
planning:Epic A single issue that documents a large project bridging multiple issues.
Projects
None yet
Development

No branches or pull requests

1 participant