Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Design System - Update Icon Map Stories #569

Open
3 of 8 tasks
paigewilliams opened this issue May 24, 2019 · 5 comments
Open
3 of 8 tasks

Design System - Update Icon Map Stories #569

paigewilliams opened this issue May 24, 2019 · 5 comments

Comments

@paigewilliams
Copy link
Contributor

paigewilliams commented May 24, 2019

What

What needs to be done?

Standard

  • Rename"Simple Usage" story to "Standard" story

  • Create knobs for each of these standard props and group as marker:
    -getIcon
    -getSize
    -iconAtlas
    -iconMapping
    -iconSizeScale
    -getColor
    -opacity

  • Create knobs for each of these standard props and group as data:
    -data
    -getPosition

Custom

  • Create "Custom" story
  • Create knobs for each of these custom props and group as custom:
    -autoHightlight
    -highlightColor
    -onLayerClick

Example

  • Rename "With tooltip" story to "Examples: With Tooltip" story
  • Rename "TouchScreenDemo" story to "Examples: Touch Screen" story

Notes

  • Add IconLayer Map Notes file

Why

Why does it need to be done? (Include links to related issues)
IconLayer Map stories should follow the Civic design system pattern established in #508, #553, and #565. Please references these files:

Button Component
-Button Stories File
-Button Notes File

Bar Chart Component
-Bar Chart stories
-Bar Chart notes

Horizontal Bar Chart Component
-Horizontal Bar Chart stories
-Horizontal Bar Chart notes

When

When does this need to be done?
In the near future

@mendozaline
Copy link
Member

@jaronheard should the TouchScreenDemo story be removed or should it be kept and be made an example story?

@mendozaline mendozaline changed the title Design System - Update IconLayer Map Design System - Update Icon Map Stories May 24, 2019
@jaronheard
Copy link
Contributor

jaronheard commented May 24, 2019 via email

@corydm92
Copy link
Contributor

I believe getPosition has a default of d => d.geometry.coordinates that should be moved to custom instead of the standard usage story.

@paigewilliams
Copy link
Contributor Author

@corydm92 Thanks for pointing that out! I have removed the getPosition knob in the ScatterPlot Map and Path Map, so it can be ignored in this issue.

@jaronheard
Copy link
Contributor

Note, recommend holding off on writing the stories for IconMap because the component is (potentially) being redesigned.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants