-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Design System - Update Icon Map Stories #569
Comments
@jaronheard should the TouchScreenDemo story be removed or should it be kept and be made an example story? |
I think we should keep it as an example. Should be useful as we work on the
OMSI project
…On Fri, May 24, 2019 at 2:39 PM David Mendoza ***@***.***> wrote:
@jaronheard <https://github.com/jaronheard> should the TouchScreenDemo
story be removed or should it be kept and be made an example story?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#569?email_source=notifications&email_token=ABV5AXYYSRB4J5ISSIA4Y4LPXBOBPA5CNFSM4HPSNJJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGTZAY#issuecomment-495795331>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABV5AXYTL5MSXYYVMI5GPO3PXBOBPANCNFSM4HPSNJJQ>
.
--
Jaron Heard
Creative Director
Civic Software Foundation
+1-971-998-7180
|
I believe getPosition has a default of d => d.geometry.coordinates that should be moved to custom instead of the standard usage story. |
@corydm92 Thanks for pointing that out! I have removed the |
Note, recommend holding off on writing the stories for IconMap because the component is (potentially) being redesigned. |
What
What needs to be done?
Standard
Rename"Simple Usage" story to "Standard" story
Create knobs for each of these standard props and group as marker:
-
getIcon
-
getSize
-
iconAtlas
-
iconMapping
-
iconSizeScale
-
getColor
-
opacity
Create knobs for each of these standard props and group as data:
-
data
-
getPosition
Custom
-
autoHightlight
-
highlightColor
-
onLayerClick
Example
Notes
Why
Why does it need to be done? (Include links to related issues)
IconLayer Map stories should follow the Civic design system pattern established in #508, #553, and #565. Please references these files:
Button Component
-Button Stories File
-Button Notes File
Bar Chart Component
-Bar Chart stories
-Bar Chart notes
Horizontal Bar Chart Component
-Horizontal Bar Chart stories
-Horizontal Bar Chart notes
When
When does this need to be done?
In the near future
The text was updated successfully, but these errors were encountered: