Design system - PieChart stories #620
Conversation
… Corrected the parameters to a numeric knob in the LineChart stories.
There was a problem hiding this comment.
The code looks great! Just some knobs to add and move around:
Standard story
Add "Data value" and "Data label" knobs to Data tab
Move "Use legend" from Labels to Design?
Custom story
Move "Data value" and "Data label" knobs from Custom to Data tab
Move "Use legend" from Labels to Design?
Adjust default width and height to below
const chartHeight = number("Chart height", 350, {}, GROUP_IDS.CUSTOM);
const chartWidth = number("Chart width", 650, {}, GROUP_IDS.CUSTOM);
…ated Notes to reflect changes.
|
I made the requested changes. Adding "Data label" and "Data value" labels to the Standard story makes it consistent with the other chart component stories! The reason I had not added it was because it wasn't used in the pie charts I found in the projects or in the existing PieChart story. The "Example: Simple" story shows the component using the default prop values for "Data label" and "Data value"; that seems the appropriate place. After making these changes, the "Start angle" and "End angle" knobs don't work. It was working, and I can't find the problem. Looking at the component, it sets the value of startAngle and endAngle based on whether the prop halfDoughnut is true or false, not on the value of the knob. I'm not sure why it was working or why it isn't working after these changes... if you could take a look I'd appreciate it. If I'm right that these knobs aren't currently changing the value of startAngle and endAngle, we could either delete them or update the component. By the way, none of the pie charts in the project have used startAngle and endAngle; perhaps it isn't useful. |
|
Awesome! I would remove the startAngle and endAngle knobs, and also remove the props in the component, since they aren't being used.
…On Wed, Jun 26, 2019 at 3:39 PM, Janice Bradford < ***@***.*** > wrote:
I made the requested changes. Adding "Data label" and "Data value" labels
to the Standard story makes it consistent with the other chart component
stories!
The reason I had not added it was because it wasn't used in the pie charts
I found in the projects or in the existing PieChart story. The "Example:
Simple" story shows the component using the default prop values for "Data
label" and "Data value"; that seems the appropriate place.
After making these changes, the "Start angle" and "End angle" knobs don't
work. It was working, and I can't find the problem. Looking at the
component, it sets the value of startAngle and endAngle based on whether
the prop halfDoughnut is true or false, not on the value of the knob. I'm
not sure why it was working or why it isn't working after these changes...
if you could take a look I'd appreciate it.
If I'm right that these knobs aren't currently changing the value of
startAngle and endAngle, we could either delete them or update the
component. By the way, none of the pie charts in the project have used
startAngle and endAngle; perhaps it isn't useful.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub (
#620?email_source=notifications&email_token=ABV5AX4JVC6KJABUGNOXTGDP4PVZJA5CNFSM4HZ3OA52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYVAOFQ#issuecomment-506070806
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/ABV5AXZAQQIFJD7SU2XYLE3P4PVZJANCNFSM4HZ3OA5Q
).
|
|
In the last commit the "Start angle" and "End angle" knobs were removed from the Custom story. The Notes were updated with this change. The component was not changed. |
This update to the PieChart component follows the Civic design system pattern established in #508, #553, and #565.
Working with the existing stories the following stories were created:
Standard - the common, default use of the PieChart component in the CIVIC platform
Custom - add knobs for all props of the PieChart component
Example: Simple - the simple story shows only the most basic props.
A notes file was added; it describes each story and list the props/knobs that can be changed.