Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove compatibility with core without frontend.add_extra_js_url #3783

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Remove compatibility with core without frontend.add_extra_js_url #3783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1c7c34
Remove compatibility with core without frontend.add_extra_js_url
emontnemery Jun 13, 2024
9eb980b
Merge branch 'main' into remove_add_extra_url_compat
ludeeus Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions custom_components/hacs/frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,15 @@
import os
from typing import TYPE_CHECKING

from homeassistant.components.frontend import async_register_built_in_panel
from homeassistant.components.frontend import (
add_extra_js_url,
async_register_built_in_panel,
)
from homeassistant.core import HomeAssistant, callback

from .const import DOMAIN, URL_BASE
from .hacs_frontend import VERSION as FE_VERSION, locate_dir

try:
from homeassistant.components.frontend import add_extra_js_url
except ImportError:

def add_extra_js_url(hass: HomeAssistant, url: str, es5: bool = False) -> None:
hacs: HacsBase = hass.data.get(DOMAIN)
hacs.log.error("Could not import add_extra_js_url from frontend.")
if "frontend_extra_module_url" not in hass.data:
hass.data["frontend_extra_module_url"] = set()
hass.data["frontend_extra_module_url"].add(url)


if TYPE_CHECKING:
from .base import HacsBase

Expand Down