fix: parse fractional arguments to flags #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse fractional numbers as arguments to flags for the `HEALTHCHECK` instruction. The `HEALTHCHECK` instruction can take an `--interval`, `--timeout` or `--start-period` flag specifying details to the healthcheck repetition behaviour. This can also be specified with fractions (of secods, minutes or hours), e.g.: ```Dockerfile HEALTHCHECK \ --interval=0.5s \ CMD curl -f http://localhost ``` With the caveat that somewhere from parsing to conversion to a DiffTime some precision is lost (DiffTime has a precision of 10^-12s), this change adds support for the arguments to these interval flags to be specified as fractional numbers. fixes: hadolint/hadolint#893 Signed-off-by: Moritz Röhrich <moritz@ildefons.de>
|
thanks again! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse fractional numbers as arguments to flags for the
HEALTHCHECKinstruction.The
HEALTHCHECKinstruction can take an--interval,--timeoutor--start-periodflag specifying details to the healthcheck repetition behaviour. This can also be specified with fractions (of secods, minutes or hours), e.g.:With the caveat that somewhere from parsing to conversion to a DiffTime some precision is lost (DiffTime has a precision of 10^-12s), this change adds support for the arguments to these interval flags to be specified as fractional numbers.
fixes: hadolint/hadolint#893
Signed-off-by: Moritz Röhrich moritz@ildefons.de