fix(core): fix the dropdown hidden trigger initialization #568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using a screen reader, such as VoiceOver, the state of the dropdown (reduced/expanded) is not read until interaction with the element is made. The following solution is proposed to fix the issue.
What has been done
assignedElements
and thefirstTabbable
didn't work properly because the trigger is aMockHTMLElement
. As the test is implemented, the easiest way to fix it would be to mock what thefirstTabbable
returns.What to test
aria-haspopup
,aria-expanded
,aria-controls
) without the need to interact with the element, even the nested dropdown (Example user menu -> Available
andNested dropdown -> Click one more time)
.