Skip to content

Commit

Permalink
fixed issue with dependency loader failing when there were 0 async sc…
Browse files Browse the repository at this point in the history 
…ripts (#214)
  • Loading branch information
@hakimel
hakimel committed Oct 29, 2012
1 parent 5c5b3d3 commit f51067b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
6 changes: 4 additions & 2 deletions js/reveal.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,10 @@ var Reveal = (function(){

// Called once synchronous scritps finish loading
function proceed() {
// Load asynchronous scripts
head.js.apply( null, scriptsAsync );
if( scriptsAsync.length ) {
// Load asynchronous scripts
head.js.apply( null, scriptsAsync );
}

start();
}
Expand Down
20 changes: 10 additions & 10 deletions js/reveal.min.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 comments on commit f51067b

@005bharat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I am using reveal.js, You have done absolutely brilliant work!
just one query in reveal.js there is one function
updateSlides(). here it makes section tag display:none.
can you please explain why you are doing this.
i mean what kind of optimization need this.
please reply.

Thank You

@005bharat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please reply..

@hakimel
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's in place because having fewer visible slides makes the presentation run faster. I tried converting to visibility: hidden; at some point but ran into issues with the transitions, may revisit that.

@005bharat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You ! Your explanation will help me a lot ! because I am facing problem with vertical slides. vertical slides doesn't transit with animation which are display:none.

Please # to comment.