Fix slide notes printing #2671
Merged
Fix slide notes printing #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-l-lee
force-pushed
the
fix-notes-printing
branch
from
39fbfdf to
4e839b3
Compare
|
Thanks for spotting and fixing that 🙌 |
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Fix slide notes printing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to
print.jsfixes anUncaught ReferenceError: getSlideNotes is not definedwhen attempting to export to PDF on Chrome with?print-pdfin the query string andshowNotesset totrue,'inline', or'separate-page'in the configuration.The change to
notes.jsfixes the notes sidebar remaining visible when attempting to export to PDF on Chrome under similar conditions as shown in the screenshot below: