Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add public method getTotalSlides() #858

Closed
wants to merge 1 commit into from
Closed

Add public method getTotalSlides() #858

wants to merge 1 commit into from

Conversation

samthill
Copy link

@samthill samthill commented Apr 1, 2014

Add public method getTotalSlides() to retrieve the total number of slides in this slide show

Add public method getTotalSlides() to retrieve the total number of slides in this slide show
hakimel added a commit that referenced this pull request Apr 1, 2014
hakimel added a commit that referenced this pull request Apr 1, 2014
@hakimel
Copy link
Owner

hakimel commented Apr 1, 2014

Good idea, this should exist in the API. The total number should exclude the vertical stacks though, otherwise a presentation with only three vertical slides would return a total count of four.

Also please submit PRs to the dev branch in the future, thanks.

@hakimel hakimel closed this Apr 1, 2014
@samthill
Copy link
Author

samthill commented Apr 1, 2014

Thanks Hakimel. Good point about vertical stacks and sorry about the pull request on prod.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants