Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: api client requests support configuring the mute parameter to hide exception toast #744

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 5, 2022

What type of PR is this?

/kind improvement
/milestone 2.0.1

What this PR does / why we need it:

使用 api-client 进行网络请求时,支持添加 mute 参数以隐藏异常提示。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2836

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

优化 Console 端接口请求异常提示。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0.1 milestone Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing December 5, 2022 07:47
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 8:54AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎无法正常显示已激活的主题了,请看截图:

image

@ruibaby
Copy link
Member Author

ruibaby commented Dec 5, 2022

似乎无法正常显示已激活的主题了,请看截图:

已修复。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 812b8ed into halo-dev:main Dec 5, 2022
@ruibaby ruibaby deleted the feat/api-client-support-mute-param branch December 6, 2022 03:01
@ruibaby
Copy link
Member Author

ruibaby commented Dec 7, 2022

/cherrypick release-2.0

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #752

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 7, 2022
…parameter to hide exception toast (#752)

This is an automated cherry-pick of #744

/assign ruibaby

```release-note
None
```
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 7, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…ide exception toast (halo-dev/console#744)

#### What type of PR is this?

/kind improvement
/milestone 2.0.1

#### What this PR does / why we need it:

使用 api-client 进行网络请求时,支持添加 `mute` 参数以隐藏异常提示。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2836

#### Special notes for your reviewer:

None

#### Does this PR introduce a user-facing change?

```release-note
None
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端的部分请求操作需要支持设置不显示异常提示
4 participants