Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: cannot save post when the publishTime is blank #763

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: cannot save post when the publishTime is blank #763

merged 1 commit into from
Dec 12, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 11, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复当文章设置中的发布时间为空字符串时，无法保存的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2906

Special notes for your reviewer:

测试方式：

  1. 进入新建文章页面。
  2. 点击右上角发布按钮，填写必要的标题和别名，然后点击保存。
  3. 点击右上角设置按钮，切换到高级设置，再次点击保存。
  4. 观察是否正常保存。

Does this PR introduce a user-facing change?

修复 Console 端文章设置中的发布时间为空字符串时，无法保存的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 11, 2022
@vercel
Copy link

vercel bot commented Dec 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 11, 2022 at 2:38PM (UTC)

guqing
guqing reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Dec 12, 2022

@halo-dev/sig-halo-console

JohnNiang
JohnNiang approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well in Firefox browser.
/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 7f9de2f into halo-dev:main Dec 12, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-2.0
/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 12, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 12, 2022
Merged
@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #764

In response to this:

/cherry-pick release-2.0
/milestone 2.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby deleted the fix/publishTime branch December 12, 2022 06:37
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 12, 2022
@halo-dev-bot
[release-2.0] fix: cannot save post when the publishTime is blank (#764)
a3caa29 
This is an automated cherry-pick of #763

/assign JohnNiang

```release-note
修复 Console 端文章设置中的发布时间为空字符串时，无法保存的问题。
```
@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 20, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
fix: cannot save post when the publishTime is blank (halo-dev/console…
42d6342 
…#763)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复当文章设置中的发布时间为空字符串时，无法保存的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2906

#### Special notes for your reviewer:

测试方式：

1. 进入新建文章页面。
2. 点击右上角发布按钮，填写必要的标题和别名，然后点击保存。
3. 点击右上角设置按钮，切换到高级设置，再次点击保存。
4. 观察是否正常保存。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端文章设置中的发布时间为空字符串时，无法保存的问题。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

在文章编辑页面打开文章设置，如果不选择日期时间会保存失败
4 participants
@ruibaby @JohnNiang @halo-dev-bot @guqing