Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add enable and upgrade support for theme list #774

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 15, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

  1. 在主题管理列表添加启用和升级的支持。
  2. 优化主题页面右上角的按钮布局
  3. 优化主题管理的代码结构。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2948

Screenshots:

image

image

Special notes for your reviewer:

测试方式:

  1. 进入主题管理,点击右上角的主题管理。
  2. 测试单个主题的启用和升级是否符合预期。

Does this PR introduce a user-facing change?

Console 端的主题管理列表添加启用和升级的支持。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 15, 2022
@vercel
Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 3:02PM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well for me.

image

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member

guqing commented Dec 16, 2022

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 6ac0816 into halo-dev:main Dec 16, 2022
@ruibaby ruibaby deleted the refactor/theme-list branch December 16, 2022 02:52
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…#774)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

1. 在主题管理列表添加启用和升级的支持。
2. 优化主题页面右上角的按钮布局
3. 优化主题管理的代码结构。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2948

#### Screenshots:

<img width="1515" alt="image" src="https://user-images.githubusercontent.com/21301288/207893631-6db10293-d0ee-4af4-9c43-f137055df28e.png">
<img width="1665" alt="image" src="https://user-images.githubusercontent.com/21301288/207894016-dd1a5d27-9fff-4211-8869-381208932eaf.png">


#### Special notes for your reviewer:

测试方式:

1. 进入主题管理,点击右上角的主题管理。
4. 测试单个主题的启用和升级是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
Console 端的主题管理列表添加启用和升级的支持。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wish the theme upgrade button could be more visible
3 participants