Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: the flickering issue of tooltip #782

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: the flickering issue of tooltip #782

merged 1 commit into from
Dec 20, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 19, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

修复 v-tooltip 指令的元素闪烁问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2994

Screenshots:

2022-12-19 21 52 11

Special notes for your reviewer:

测试方式：

  1. 创建一篇文章，仅保存不发布。
  2. 回到文章管理列表，可以看到标题旁边有一个状态点，鼠标移入会显示提示。
  3. 观察是否出现闪烁的问题。

Does this PR introduce a user-facing change?

优化 Console 端状态提示的样式

@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 19, 2022 at 1:57PM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 19, 2022
@ruibaby ruibaby mentioned this pull request Dec 19, 2022
Closed
JohnNiang
JohnNiang approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@Aanko
Copy link
Contributor

Aanko commented Dec 20, 2022

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aanko, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang
Copy link
Member

/cherry-pick release-2.0

@JohnNiang JohnNiang added this to the 2.1.x milestone Dec 20, 2022
@halo-dev-bot
Copy link

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JohnNiang
JohnNiang reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 2c3147a into halo-dev:main Dec 20, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 20, 2022
Merged
@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #783

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 20, 2022
@halo-dev-bot
[release-2.0] fix: the flickering issue of tooltip (#783)
be1c500 
This is an automated cherry-pick of #782

/assign JohnNiang

```release-note
优化 Console 端状态提示的样式
```
@ruibaby ruibaby deleted the perf/tooltip-flickers branch December 20, 2022 02:44
@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 20, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
fix: the flickering issue of tooltip (halo-dev/console#782)
ad1f7d4 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

修复 `v-tooltip` 指令的元素闪烁问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2994

#### Screenshots:

![2022-12-19 21 52 11](https://user-images.githubusercontent.com/21301288/208441007-2bffe6f6-0b48-4a90-86a0-31ce622f04bf.gif)

#### Special notes for your reviewer:

测试方式：

1. 创建一篇文章，仅保存不发布。
2. 回到文章管理列表，可以看到标题旁边有一个状态点，鼠标移入会显示提示。
3. 观察是否出现闪烁的问题。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端状态提示的样式
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@Aanko Aanko Awaiting requested review from Aanko

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

状态点(status dot)的悬浮提示跟着闪，需要提升体验
4 participants
@ruibaby @Aanko @JohnNiang @halo-dev-bot