This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: attachment upload component #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ruibaby
added
the
kind/improvement
|
上传小按钮似乎不太直观，请看以下截图：
|
这个按钮放在哪儿都不太合适，等我想想。 |
|
已改为： |
|
点击上传按钮之后，没有正确携带 group 信息。 |
因为分组和策略会记住上次选的。 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 优化上传附件的组件和附件库选择组件。 1. 附件上传支持缓存选择的分组和策略。 2. 附件上传支持选择分组。 3. 移除附件选择组件的上传 tab，改为和附件库管理中一样的上传组件。 #### Which issue(s) this PR fixes: Fixes halo-dev#2828 #### Screenshots: <img width="722" alt="image" src="https://user-images.githubusercontent.com/21301288/208612167-c7082be4-0fb8-4caa-b246-d15bac525e86.png"> #### Special notes for your reviewer: 测试方式： 1. 测试在附件管理中上传附件的功能是否正常。 2. 测试在附件选择组件中上传附件的功能是否正常。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端上传附件的功能，支持缓存选择的分组和策略。 ```
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
优化上传附件的组件和附件库选择组件。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#2828
Screenshots:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?