Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add full-functional post category select component for formkit #818

Merged
merged 11 commits into from
Jan 16, 2023
Merged

feat: add full-functional post category select component for formkit #818

merged 11 commits into from
Jan 16, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 11, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

添加功能更为全面的文章分类选择器，支持以下特性：

  1. 按层级展示分类
  2. 支持搜索
  3. 选中结果支持显示层级

todo list:

  • 样式整理
  • 支持创建新分类

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2670
Fixes halo-dev/halo#2485

Screenshots:

image

image

Special notes for your reviewer:

Does this PR introduce a user-facing change?

重构 Console 端的文章分类选择器。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 11, 2023
@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Jan 16, 2023 at 3:39AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 11, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2023
@ruibaby ruibaby changed the title WIP: feat: add full functional post category select component for formkit WIP: feat: add full【functional post category select component for formkit Jan 11, 2023
@ruibaby ruibaby changed the title WIP: feat: add full【functional post category select component for formkit WIP: feat: add full-functional post category select component for formkit Jan 11, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jan 12, 2023

有一个问题，目前已经有了叫做 categorySelect 的 FormKit 类型：https://docs.halo.run/developer-guide/form-schema#categoryselect

这个类型之前只用来查询和选择单个分类，那么这个新增的组件应该叫什么名字好呢？

/cc @halo-dev/sig-halo-console

@guqing
Copy link
Member

guqing commented Jan 12, 2023

categoryMultiSelect?

@ruibaby
Copy link
Member Author

ruibaby commented Jan 12, 2023

categoryMultiSelect?

我先尝试是否能够兼容以前的 categorySelect 单选，然后提供一个 multiple 参数来支持多选。

@guqing
Copy link
Member

guqing commented Jan 12, 2023

categoryMultiSelect?

我先尝试是否能够兼容以前的 categorySelect 单选，然后提供一个 multiple 参数来支持多选。

如果能直接在原来的 categorySelect 基础上通过参数的方式支持更多设置比如是否多选，那就更好了

@ruibaby
Copy link
Member Author

ruibaby commented Jan 12, 2023

如果能直接在原来的 categorySelect 基础上通过参数的方式支持更多设置比如是否多选，那就更好了

tagSelect 已经支持：#817

@ruibaby
Copy link
Member Author

ruibaby commented Jan 12, 2023

/retitle feat: add full-functional post category select component for formkit

ping @halo-dev/sig-halo-console

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: add full-functional post category select component for formkit feat: add full-functional post category select component for formkit Jan 12, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jan 13, 2023 •
edited
Loading

ping @halo-dev/sig-halo-console

guqing
guqing reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@ruibaby ruibaby added this to the 2.2.x milestone Jan 13, 2023
JohnNiang
JohnNiang approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9d5529b into halo-dev:main Jan 16, 2023
@wan92hen
Copy link
Contributor

棒！

@ruibaby ruibaby deleted the feat/post-category-select-for-formkit branch January 16, 2023 08:19
@JohnNiang JohnNiang modified the milestones: 2.2.x, 2.2.0 Jan 30, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
feat: add full-functional post category select component for formkit (h…
c8dfdc8 
…alo-dev/console#818)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

添加功能更为全面的文章分类选择器，支持以下特性：

1. 按层级展示分类
2. 支持搜索
3. 选中结果支持显示层级

todo list:

- [x] 样式整理
- [x] 支持创建新分类

#### Which issue(s) this PR fixes:

Fixes halo-dev#2670
Fixes halo-dev#2485

#### Screenshots:

<img width="832" alt="image" src="https://user-images.githubusercontent.com/21301288/211768419-087d9727-1468-41a1-868a-62d90eef9cca.png">
<img width="858" alt="image" src="https://user-images.githubusercontent.com/21301288/211768478-dcc70d79-127b-42b0-ae44-e48a6a22273a.png">


#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
重构 Console 端的文章分类选择器。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

优化 Console 端文章设置中的标签和分类设置 设置文章分类时展示分类层级
4 participants
@ruibaby @guqing @wan92hen @JohnNiang