Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: update comment list sorter #821

Merged
merged 3 commits into from
Jan 16, 2023
Merged

feat: update comment list sorter #821

merged 3 commits into from
Jan 16, 2023

Conversation

vayci
Copy link
Contributor

@vayci vayci commented Jan 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

修改评论列表默认排序规则,以实现最新评论或最新回复的评论总显示在最前

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3138

Screenshots:

image

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修改评论列表默认排序规则,排序方式新增“最后回复时间”排序方式

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby January 13, 2023 06:17
@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Jan 16, 2023 at 3:05AM (UTC)

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2023
@ruibaby ruibaby added this to the 2.2.x milestone Jan 15, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c55f662 into halo-dev:main Jan 16, 2023
@JohnNiang JohnNiang modified the milestones: 2.2.x, 2.2.0 Jan 30, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

修改评论列表默认排序规则,以实现最新评论或最新回复的评论总显示在最前

#### Which issue(s) this PR fixes:

Fixes halo-dev#3138

#### Screenshots:

![image](https://user-images.githubusercontent.com/17878156/212250458-edaeb149-8c3f-411d-b72b-5a70677cd300.png)

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
修改评论列表默认排序规则,排序方式新增“最后回复时间”排序方式
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

需要优化 Console 端评论的默认排序规则
3 participants