This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 482
perf: change attachment list layout to list mode #827
Merged
f2c-ci-robot
merged 1 commit into
halo-dev:main
from
ruibaby:perf/attachment-default-layout
Jan 18, 2023
Merged
perf: change attachment list layout to list mode #827
f2c-ci-robot
merged 1 commit into
halo-dev:main
from
ruibaby:perf/attachment-default-layout
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/improvement
Categorizes issue or PR as related to a improvement.
labels
Jan 17, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohnNiang
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 18, 2023
guqing
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 目前暂时没有缩略图功能,上传大量的大型图片很容易造成浏览器崩溃,故我们临时将附件管理的默认视图模式改为列表模式。 #### Which issue(s) this PR fixes: Fixes halo-dev#3167 #### Screenshots: <img width="1692" alt="image" src="https://user-images.githubusercontent.com/21301288/212832865-f1f22ce2-860f-497a-b091-b4552458bd77.png"> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note Console 附件管理的默认视图模式改为列表模式。 ```
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/improvement
Categorizes issue or PR as related to a improvement.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
目前暂时没有缩略图功能,上传大量的大型图片很容易造成浏览器崩溃,故我们临时将附件管理的默认视图模式改为列表模式。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3167
Screenshots:
Special notes for your reviewer:
Does this PR introduce a user-facing change?