Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: change attachment list layout to list mode #827

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 17, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

目前暂时没有缩略图功能,上传大量的大型图片很容易造成浏览器崩溃,故我们临时将附件管理的默认视图模式改为列表模式。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3167

Screenshots:

image

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Console 附件管理的默认视图模式改为列表模式。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jan 17, 2023
@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 7:13AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit dd4ab87 into halo-dev:main Jan 18, 2023
@ruibaby ruibaby deleted the perf/attachment-default-layout branch January 18, 2023 11:49
@ruibaby ruibaby added this to the 2.2.0 milestone Jan 31, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

目前暂时没有缩略图功能,上传大量的大型图片很容易造成浏览器崩溃,故我们临时将附件管理的默认视图模式改为列表模式。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3167

#### Screenshots:

<img width="1692" alt="image" src="https://user-images.githubusercontent.com/21301288/212832865-f1f22ce2-860f-497a-b091-b4552458bd77.png">


#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?


```release-note
Console 附件管理的默认视图模式改为列表模式。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

附件管理默认排版改为列表模式
3 participants