-
Notifications
You must be signed in to change notification settings - Fork 482
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/cherrypick release-2.2 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@halo-dev/sig-halo-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-2.2 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ruibaby: #847 failed to apply on top of branch "release-2.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-2.2 |
@ruibaby: #847 failed to apply on top of branch "release-2.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-2.2 |
@ruibaby: new pull request created: #856 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #847 /assign ruibaby ```release-note 优化 Console 端用户角色标识的显示名称。 ```
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构获取用户信息的请求方式,无需再请求所有角色即可获取当前用户的角色信息,适配:halo-dev/halo#3372 相关 PR:#847 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#3342 #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev/halo#3372 分支。 2. Console 需要 `pnpm install && pnpm build:packages` 3. 测试用户列表、登录、检查角色信息是否显示正确。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 为系统初始化的角色添加显示名称 #### Which issue(s) this PR fixes: Fixes halo-dev#3257 #### Screenshots: <img width="1668" alt="image" src="https://user-images.githubusercontent.com/21301288/218020794-696420c4-69bb-4422-9409-482bb2aff708.png"> #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到:halo-dev#3280 2. 检查 Console 端显示的系统角色是否正常。 3. 新建若干自定义角色,检查名称是否正常。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构获取用户信息的请求方式,无需再请求所有角色即可获取当前用户的角色信息,适配:halo-dev#3372 相关 PR:halo-dev/console#847 #### Which issue(s) this PR fixes: Fixes halo-dev#3342 #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev#3372 分支。 2. Console 需要 `pnpm install && pnpm build:packages` 3. 测试用户列表、登录、检查角色信息是否显示正确。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端用户角色标识的显示名称。 ```
What type of PR is this?
/kind improvement
What this PR does / why we need it:
为系统初始化的角色添加显示名称
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3257
Screenshots:
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?