This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 482
feat: add layer-closeable prop for modal #861
Merged
f2c-ci-robot
merged 3 commits into
halo-dev:main
from
ruibaby:feat/add-layer-closeable-to-modal
Feb 17, 2023
Merged
feat: add layer-closeable prop for modal #861
f2c-ci-robot
merged 3 commits into
halo-dev:main
from
ruibaby:feat/add-layer-closeable-to-modal
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
labels
Feb 17, 2023
ruibaby
changed the title
WIP: feat: add layer-closeable prop for modal
feat: add layer-closeable prop for modal
Feb 17, 2023
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Feb 17, 2023
ruibaby
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Feb 17, 2023
JohnNiang
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 17, 2023
guqing
reviewed
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
合并后 links 插件也需要修改一下
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind feature #### What this PR does / why we need it: VModal 组件支持设置是否允许点击蒙层以关闭模态框,并将所有包含表单的模态框设置为不允许点击蒙层关闭。 #### Which issue(s) this PR fixes: Fixes halo-dev#3328 #### Screenshots: ![2023-02-17 12 08 56](https://user-images.githubusercontent.com/21301288/219547318-d7c59742-8546-4bc8-9d49-fcff4053602f.gif) #### Special notes for your reviewer: 测试方式: 1. 打开 Console 端任意一个表单模态框,测试点击表单外部区域是否会关闭弹框。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端部分包含表单的模态框,默认不允许点击外部区域关闭模态框。 ```
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
VModal 组件支持设置是否允许点击蒙层以关闭模态框,并将所有包含表单的模态框设置为不允许点击蒙层关闭。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3328
Screenshots:
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?