Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add layer-closeable prop for modal #861

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 16, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

VModal 组件支持设置是否允许点击蒙层以关闭模态框,并将所有包含表单的模态框设置为不允许点击蒙层关闭。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3328

Screenshots:

2023-02-17 12 08 56

Special notes for your reviewer:

测试方式:

  1. 打开 Console 端任意一个表单模态框,测试点击表单外部区域是否会关闭弹框。

Does this PR introduce a user-facing change?

优化 Console 端部分包含表单的模态框,默认不允许点击外部区域关闭模态框。

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 6:36AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 17, 2023
@ruibaby ruibaby changed the title WIP: feat: add layer-closeable prop for modal feat: add layer-closeable prop for modal Feb 17, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 17, 2023
@ruibaby ruibaby added this to the 2.3.x milestone Feb 17, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
合并后 links 插件也需要修改一下

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c8dbd24 into halo-dev:main Feb 17, 2023
@ruibaby ruibaby deleted the feat/add-layer-closeable-to-modal branch February 17, 2023 07:39
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 21, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

VModal 组件支持设置是否允许点击蒙层以关闭模态框,并将所有包含表单的模态框设置为不允许点击蒙层关闭。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3328

#### Screenshots:

![2023-02-17 12 08 56](https://user-images.githubusercontent.com/21301288/219547318-d7c59742-8546-4bc8-9d49-fcff4053602f.gif)


#### Special notes for your reviewer:

测试方式:

1. 打开 Console 端任意一个表单模态框,测试点击表单外部区域是否会关闭弹框。

#### Does this PR introduce a user-facing change?


```release-note
优化 Console 端部分包含表单的模态框,默认不允许点击外部区域关闭模态框。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望 Console 端的 Modal 组件支持设置是否可以点击蒙层以关闭
3 participants