Add forgotten label for system-reserved roles #2865
Conversation
f2c-ci-robot
bot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/cherry-pick release-2.0 |
|
@JohnNiang: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/halo-dev-bot/halo\n ! [remote rejected] cherry-pick-2865-to-release-2.0 -> cherry-pick-2865-to-release-2.0 (refusing to allow a Personal Access Token to create or update workflow In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-2.0 |
|
@JohnNiang: new pull request created: #2869 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2865 /assign JohnNiang ```release-note 修复每个角色都显示系统保留标签的问题 ```
#### What type of PR is this? /kind improvement /milestone 2.0.1 #### What this PR does / why we need it: 完善用户角色的相关逻辑。适配 halo-dev/halo#2865 1. 支持标识是否是系统保留角色。 2. 根据是否是系统保留角色，禁用修改和删除的操作。 3. 支持判断是否是超级管理员，如果是，默认勾选所有权限。 4. 优化 `包含 N 个权限` 文案的逻辑，超级管理员为 `包含所有权限`。 5. 优化 `基于此角色创建` 的逻辑，判断是否为超级管理员，如果是，需要设置所有角色模板到创建表单。 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#2844 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/205965292-b8f8e556-e06b-422b-b0be-8d87a68f18be.png"> <img width="1661" alt="image" src="https://user-images.githubusercontent.com/21301288/205965333-1491c023-6726-4cdd-b970-d868a30f3296.png"> #### Special notes for your reviewer: 测试方式： 1. Halo 需要切换到 halo-dev/halo#2865 分支。 2. 测试角色相关的所有功能。 #### Does this PR introduce a user-facing change? ```release-note 完善 Console 端用户角色的相关逻辑 ```
#### What type of PR is this? /kind improvement /milestone 2.0.1 #### What this PR does / why we need it: 完善用户角色的相关逻辑。适配 halo-dev#2865 1. 支持标识是否是系统保留角色。 2. 根据是否是系统保留角色，禁用修改和删除的操作。 3. 支持判断是否是超级管理员，如果是，默认勾选所有权限。 4. 优化 `包含 N 个权限` 文案的逻辑，超级管理员为 `包含所有权限`。 5. 优化 `基于此角色创建` 的逻辑，判断是否为超级管理员，如果是，需要设置所有角色模板到创建表单。 #### Which issue(s) this PR fixes: Fixes halo-dev#2844 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/205965292-b8f8e556-e06b-422b-b0be-8d87a68f18be.png"> <img width="1661" alt="image" src="https://user-images.githubusercontent.com/21301288/205965333-1491c023-6726-4cdd-b970-d868a30f3296.png"> #### Special notes for your reviewer: 测试方式： 1. Halo 需要切换到 halo-dev#2865 分支。 2. 测试角色相关的所有功能。 #### Does this PR introduce a user-facing change? ```release-note 完善 Console 端用户角色的相关逻辑 ```
What type of PR is this?
/kind bug
/area core
What this PR does / why we need it:
Add forgotten label
rbac.authorization.halo.run/system-reservedfor system-reserved roles. See the screenshot below:Which issue(s) this PR fixes:
Fixes #2844
Special notes for your reviewer:
For @halo-dev/sig-halo-console : We have to determine whether the role is system-reserved by checking if label
rbac.authorization.halo.run/system-reservedis equal totrue.Does this PR introduce a user-facing change?