Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: single page does not count visits #2918

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: single page does not count visits #2918

merged 1 commit into from
Dec 12, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 12, 2022

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

修复自定义页面没有统计访问量的问题

Which issue(s) this PR fixes:

Fixes #2912

Special notes for your reviewer:

how to test it?
创建自定义页面并到主题端访问，可以看到访问量增加

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

修复自定义页面没有统计访问量的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Dec 12, 2022
ruibaby
ruibaby reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
JohnNiang
JohnNiang approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-2.0

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot merged commit 52906f2 into halo-dev:main Dec 12, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 12, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #2920

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 12, 2022
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 12, 2022
@halo-dev-bot
[release-2.0] fix: single page does not count visits (#2920)
801a422 
This is an automated cherry-pick of #2918

/assign JohnNiang

```release-note
修复自定义页面没有统计访问量的问题
```
@guqing guqing deleted the fix/2912 branch December 12, 2022 04:26
@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 14, 2022
@guqing guqing mentioned this pull request Dec 19, 2022
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 20, 2022
@guqing
fix: page stats does not subscribe in finder (#3003)
9d6bcdf 
#### What type of PR is this?
/kind bug
/area core
#### What this PR does / why we need it:
修复自定义页面 Finder 中 getByName 方法没有返回访问量的问题
此问题为重构 #2918 时引入。

#### Which issue(s) this PR fixes:

Fixes #2992

#### Special notes for your reviewer:
/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?
```release-note
None
```
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

发现后台配置得自定义页面，不会统计阅读量
4 participants
@guqing @JohnNiang @halo-dev-bot @ruibaby