Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add the lastModifyTime attribute for post and single page #3101

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jan 3, 2023

What type of PR is this?

/kind improvement
/milestone 2.2.x

What this PR does / why we need it:

文章和自定义页面支持展示最后修改时间

  • 文章发布后会同步 post.spec.releasedSnapshot 记录的最后修改时间到 post.status.lastModifyTime,自定义页面亦如是。
  • 主题端可以通过 ${item.status.lastModifyTime} 获取(item表示文章或自定义页面 Vo)。

Which issue(s) this PR fixes:

Fixes #3090

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

文章和自定义页面支持展示最后修改时间

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jan 3, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.2.x milestone Jan 3, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于已经发布的文章,似乎没有正确同步 lastModifyTime

@guqing
Copy link
Member Author

guqing commented Jan 4, 2023

对于已经发布的文章,似乎没有正确同步 lastModifyTime

已修复

@guqing guqing requested a review from JohnNiang January 4, 2023 09:57
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9740de8 into halo-dev:main Jan 5, 2023
@JohnNiang JohnNiang modified the milestones: 2.2.x, 2.2.0 Jan 9, 2023
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Feb 1, 2023
…lated vo (#175)

为主题开发文档中关于文章和自定义页面的 VO 描述添加 lastModifyTime 字段。后端改动见:halo-dev/halo#3101

/kind documentation

Fixes #169 

```release-note
None
```
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

halo在2.1.0版本中取消了 文章的最后更新时间 这一属性吗?
3 participants