Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: display unapproved comments created by the current user #3102

Merged
merged 2 commits into from
Jan 9, 2023
Merged

feat: display unapproved comments created by the current user #3102

merged 2 commits into from
Jan 9, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jan 4, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.2.x

What this PR does / why we need it:

主题端显示当前用户创建的未审核通过的评论/回复

在开启了评论审核功能的前提下：

  • 如果非匿名用户在主题端创建的评论或回复必须审核通过才能显示。
  • 如果用户登录后评论或回复会被立即展示在列表，但仅限创建者可见，审核通过后对所有人可见。

Which issue(s) this PR fixes:

Fixes #2731

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

主题端支持显示当前用户创建的未审核的评论

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 4, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.2.x milestone Jan 4, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jan 4, 2023
ruibaby
ruibaby reviewed Jan 8, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

/lgtm

经过测试符合预期。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2023
@ruibaby
Copy link
Member

ruibaby commented Jan 8, 2023

需要注意的是，https://github.com/halo-sigs/plugin-comment-widget 需要对此进行优化，应该要显示正在审核的状态。

JohnNiang
JohnNiang approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 92e57b0 into halo-dev:main Jan 9, 2023
@guqing guqing deleted the feature/2731 branch January 9, 2023 09:43
@ruibaby ruibaby modified the milestones: 2.2.x, 2.2.0 Jan 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

主题端可以显示当前用户创建的未审核通过的评论
3 participants
@guqing @ruibaby @JohnNiang