Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the problem of slug name with percent sign when publishing post #3179

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix the problem of slug name with percent sign when publishing post #3179

merged 1 commit into from
Jan 30, 2023

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.2.x

What this PR does / why we need it:

Remove URI decode operation while inserting key into RadixRouterTree to avoid repeat decode.

Which issue(s) this PR fixes:

Fixes #3178

Special notes for your reviewer:

  1. Set slug name to 1%1 when creating a post
  2. Publish it
  3. Browse the post

Does this PR introduce a user-facing change?

修复因别名包含百分号导致无法正常访问的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 28, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.2.x milestone Jan 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jan 28, 2023
ruibaby
ruibaby reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
guqing
guqing reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 7188464 into halo-dev:main Jan 30, 2023
@ruibaby
Copy link
Member

ruibaby commented Jan 30, 2023

/cherry-pick release-2.1

@halo-dev-bot halo-dev-bot mentioned this pull request Jan 30, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #3183

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Jan 30, 2023
@halo-dev-bot
[release-2.1] Fix the problem of slug name with percent sign when pub…
2e491e0 
…lishing post (#3183)

This is an automated cherry-pick of #3179

/assign ruibaby

```release-note
修复因别名包含百分号导致无法正常访问的问题
```
@JohnNiang JohnNiang modified the milestones: 2.2.x, 2.2.0 Jan 30, 2023
@JohnNiang JohnNiang deleted the bug/invalid-encoded-sequence branch January 30, 2023 07:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby left review comments

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@minliacom minliacom Awaiting requested review from minliacom

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

文章标题含百分号%，导致文章无法发布，且查看时报500
4 participants
@JohnNiang @ruibaby @halo-dev-bot @guqing