Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: add docker-compose for development env #4

Merged
merged 3 commits into from
Sep 15, 2022
Merged

docs: add docker-compose for development env #4

merged 3 commits into from
Sep 15, 2022

Conversation

wan92hen
Copy link
Contributor

@wan92hen wan92hen commented Sep 14, 2022 •
edited
Loading 

docs: add docker-compose for development env

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 14, 2022
@wan92hen
Copy link
Contributor Author 

docs: add docker-compose for development env

/cc @halo-sigs/halo

ruibaby
ruibaby requested changes Sep 14, 2022
View reviewed changes
compose/README.md Outdated Show resolved Hide resolved
compose/README.md Outdated Show resolved Hide resolved
wan92hen and others added 2 commits September 14, 2022 21:59
@wan92hen @ruibaby
Update compose/README.md
9134703 
Co-authored-by: Ryan Wang <i@ryanc.cc>
@wan92hen @ruibaby
Update compose/README.md
6146105 
Co-authored-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Sep 14, 2022

似乎也可以提供一个 VS Code 的 Dev Container 配置，但不知道目前 VS Code 的 Java 支持程度如何。

参考：https://code.visualstudio.com/docs/remote/containers

示例：https://github.com/requarks/wiki/tree/main/.devcontainer

ruibaby
ruibaby reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
guqing
guqing reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang
Copy link
Member

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 15, 2022
@ruibaby
Copy link
Member

ruibaby commented Sep 15, 2022

现在这个仓库还没有 OWNERS，我先手动合并。

@ruibaby ruibaby merged commit 3b023dd into halo-dev:main Sep 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby requested changes

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wan92hen @ruibaby @JohnNiang @guqing