feat(books): Delete and edit book #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedl4
reviewed
May 23, 2017
src/app/books/book.service.ts
Outdated
| .then((response) => { | ||
| console.log(response); | ||
| return response.json().data as Book[]; | ||
| .then(response => { |
There was a problem hiding this comment.
Why do you want change this? It is necessary for something
There was a problem hiding this comment.
I think it's just a something I have misplaced. I'll check it out just in case
There was a problem hiding this comment.
it's done now. You were right.
josedl4
reviewed
May 23, 2017
|
|
||
| constructor(private modalService: NgbModal) { } |
There was a problem hiding this comment.
Why did you remove this argument?
There was a problem hiding this comment.
It was just a change I made on the name. I'll check it again.
There was a problem hiding this comment.
it's done now. You were right.
emisansev
commented
May 24, 2017
|
|
||
| constructor(private modalService: NgbModal) { } |
There was a problem hiding this comment.
It was just a change I made on the name. I'll check it again.
src/app/books/book.service.ts
Outdated
| .then((response) => { | ||
| console.log(response); | ||
| return response.json().data as Book[]; | ||
| .then(response => { |
There was a problem hiding this comment.
I think it's just a something I have misplaced. I'll check it out just in case
jorge-sanz
requested changes
May 24, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.